15 Sep
2021
15 Sep
'21
5:12 p.m.
Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57633 )
Change subject: ich_descriptors: Explicitly check for Ibex Peak ISL value ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3: I just noticed that this patch effectively undoes some of the changes from CB:55651. Should we just revert that patch now that we know the assumption made is incorrect, at least in the `ICCRIBA == 0x00` case?
--
To view, visit https://review.coreboot.org/c/flashrom/+/57633
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2b6301c6cd08f6822340d61a3454b31fddc3be52
Gerrit-Change-Number: 57633
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: David Hendricks
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Angel Pons angel.pons@9elements.com
Gerrit-Comment-Date: Wed, 15 Sep 2021 17:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment