Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33830 )
Change subject: flashchips.c: end of line comment consistency
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/33830/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/33830/1/flashchips.c@2772
PS1, Line 2772: .printlock = spi_prettyprint_status_register_at45db,
: .unlock = spi_disable_blockprotect_at45db, /* Impossible if locked down or #WP is low */
Just noticed these entries got switched, is it intentional? Several other places have that as well.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic4f97454766eff640b26a6c6eca29dc56c34c444
Gerrit-Change-Number: 33830
Gerrit-PatchSet: 1
Gerrit-Owner: Alan Green
avg@google.com
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jun 2019 07:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment