Attention is currently required from: Alexander Goncharov, Edward O'Callaghan, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75877?usp=email )
Change subject: flashchips: change chip lock status funcs for Winbond chips
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Nikolai, I think we need your code review over here. Thank you so much!
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/75877/comment/28709d25_3fae3cc6 :
PS2, Line 17877: SPI_PRETTYPRINT_STATUS_REGISTER_AMIC_A25L032
I wanted to ask, how did you pick the printlock func? (I want to understand for myself).
Also I am wondering, what happens if, just theoretically, a wrong func is chosen? Will print wrong values or breaks (like segfault or something)?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75877?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5066863b514825aee0dffe496492514ac99b6e49
Gerrit-Change-Number: 75877
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Fri, 30 Jun 2023 09:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment