Nico Huber has posted comments on this change. ( https://review.coreboot.org/28087 )
Change subject: Add initial J-Link SPI programmer ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/28087/2/jlink_spi.c File jlink_spi.c:
https://review.coreboot.org/#/c/28087/2/jlink_spi.c@344 PS2, Line 344:
No, the device instance is not free'd because we still have a reference on it (jaylink_open())
Ack, I checked their code... not that they cared to document this side effect of jaylink_open().
https://review.coreboot.org/#/c/28087/4/jlink_spi.c File jlink_spi.c:
https://review.coreboot.org/#/c/28087/4/jlink_spi.c@214 PS4, Line 214: && strlen(arg) > 0 same here...
https://review.coreboot.org/#/c/28087/4/jlink_spi.c@237 PS4, Line 237: && strlen(arg) > 0 and there?