Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51925 )
Change subject: [WIP] replace programmer enum with a pointer to programmer_entry
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
Patchset:
PS5:
Makefile:
internal.c:173:5: error: no previous prototype for 'internal_init' [-Werror=missing-prototypes]
173 | int internal_init(void)
| ^~~~~~~~~~~~~
Meson runs without errors
Maybe the init function need to be static now
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51925
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7435ee2bb661e4f139034bb289b84ebd41e1e9e9
Gerrit-Change-Number: 51925
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xiang Wang
wxjstz@126.com
Gerrit-Comment-Date: Wed, 05 May 2021 14:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment