Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34621 )
Change subject: helpers: Implement strndup() for MinGW ......................................................................
Patch Set 5:
(3 comments)
Thanks for the review!
https://review.coreboot.org/c/flashrom/+/34621/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34621/4//COMMIT_MSG@6 PS4, Line 6:
Add a summary line, e.g. […]
Done
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c File helpers.c:
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@109 PS4, Line 109: if(strlen(src) > maxlen) {
Add a space after `if`, please.
Done
https://review.coreboot.org/c/flashrom/+/34621/4/helpers.c@112 PS4, Line 112: memcpy( retbuf, src, maxlen );
spaces...
Done