[flashrom-gerrit] Change in flashrom[master]: sb600spi: Add spireadmode

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38833 )

Change subject: sb600spi: Add spireadmode
......................................................................

Patch Set 3: Code-Review-1

(2 comments)

Juuust one last thing.

https://review.coreboot.org/c/flashrom/+/38833/1/sb600spi.c 
File sb600spi.c:

https://review.coreboot.org/c/flashrom/+/38833/1/sb600spi.c@509 
PS1, Line 509: if (spispeed_idx >= 0 && set_speed(dev, spispeed_idx) != 0) {
             : 		return 1;
             : 	}
             : 	return 0;
> set_speed only writes to the register for setting the speed. Skipping this is intentional. […]

Ack

https://review.coreboot.org/c/flashrom/+/38833/3/sb600spi.c 
File sb600spi.c:

https://review.coreboot.org/c/flashrom/+/38833/3/sb600spi.c@453 
PS3, Line 453: (amd_gen < CHIPSET_BOLTON)
This would prevent reaching the warning message below.