Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nicholas Chin.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing
......................................................................
Patch Set 16:
(3 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/5def3b1f_63ae27dd
PS15, Line 154: msg_pdbg("VL805 firmware version 0x%08x\n", val);
On some compilers we have problems with printing fixed size integers. […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/72bdfb62_7fa62970
PS15, Line 175: register_spi_master(&spi_master_vl805, dev);
This `register_master` musst be removed.
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/cad06811_5d9d0076
PS15, Line 177: return 0;
return the result of register_spi_master() […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I71435afcacdf97e14d627e35bce3d29de9657f38
Gerrit-Change-Number: 72057
Gerrit-PatchSet: 16
Gerrit-Owner: ChrisEric1 CECL
christopherericlentocha@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Wed, 15 Feb 2023 13:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment
