12 Apr
2022
12 Apr
'22
11:38 p.m.
Attention is currently required from: Mimoja. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37987 )
Change subject: chipset_enable.c: Add Ice Lake U to known and tested systems ......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
This DID is not belongs to Icelake SPI controller -> 0x3482, rather this is ice lake LP PCH premium […]
No, flashrom uses the LPC device's PCI IDs. The SPI PCI device isn't always visible: I have an HP 280 G2 mainboard (LGA1151 socket with Sunrise Point H110 PCH) where vendor firmware hides the SPI PCI device.
--
To view, visit https://review.coreboot.org/c/flashrom/+/37987
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6227d32f4476420cf1aeec37ebd4b7648e0b3d15
Gerrit-Change-Number: 37987
Gerrit-PatchSet: 8
Gerrit-Owner: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christoph Pomaska github@slrie.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Mimoja coreboot@mimoja.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Subrata Banik subratabanik@google.com
Gerrit-Attention: Mimoja coreboot@mimoja.de
Gerrit-Comment-Date: Tue, 12 Apr 2022 21:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment