Attention is currently required from: Nico Huber, Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55118 )
Change subject: print.c: use static string for internal programmer name
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55118/comment/5f031d52_071b9ae3
PS3, Line 7: programmer_table: print.c use fixed fixed name instead of reference
How about `print. […]
Done
File print.c:
https://review.coreboot.org/c/flashrom/+/55118/comment/f1e89781_3153d6dd
PS3, Line 478: programmer_table[PROGRAMMER_INTERNAL]->name
How about `programmer_internal->name`?
The code is explicit for the internal programmer. And similar code uses also a static string. ¯_(ツ)_/¯
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55118
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805
Gerrit-Change-Number: 55118
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 10:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment