28 Apr
2021
28 Apr
'21
2:35 a.m.
Attention is currently required from: Nico Huber, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52684 )
Change subject: ene_lpc.c: Extract params check into a function ......................................................................
Patch Set 2:
(1 comment)
File ene_lpc.c:
https://review.coreboot.org/c/flashrom/+/52684/comment/7760832a_9f1db6b0 PS1, Line 519: = NULL
heh, I knew I missed something :) it's not a nit IMHO, static analysis […]
Done, and also in mec1308 is the same check_params() function: https://review.coreboot.org/c/flashrom/+/52719
--
To view, visit https://review.coreboot.org/c/flashrom/+/52684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7c3b6dea0edbc7547f0b307a0508c7d2b2a6d370
Gerrit-Change-Number: 52684
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-CC: Victor Ding victording@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 28 Apr 2021 02:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment