Attention is currently required from: Wonkyu Kim, Subrata Banik, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake ......................................................................
Patch Set 5: Code-Review+1
(3 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/5f5440f5_69b56c34 PS5, Line 310: case CHIPSET_METEOR_LAKE: Is this correct?
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/a3938bb0_2ad66022 PS5, Line 2062: ich_gen == CHIPSET_METEOR_LAKE)) { Please keep this aligned with the previous conditions. The indentation with 5 spaces is intentional, as it visually separates the condition from the body of the if-block.
File programmer.h:
https://review.coreboot.org/c/flashrom/+/62783/comment/f58765fd_29450e8b PS5, Line 357: CHIPSET_METEOR_LAKE, Any particular reason to put this here? I'd expect this to come after `CHIPSET_ELKHART_LAKE` to preserve chronological ordering and PCH/non-PCH grouping.
Or is this placed after `CHIPSET_600_SERIES_ALDER_POINT`?