Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35592 )
Change subject: cli_classic: Add convenient '--{flash,get}-size' cli opt
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35592/10/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35592/10/cli_classic.c@629
PS10, Line 629: if (!(read_it | write_it | verify_it | erase_it | flash_name | flash_size)) {
NB. […]
Let me think about these cli clean ups in further follow ups. I think there is a couple more things to be done around the cli in general to make it more robust and maintainable.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f002f3b2012aec4d26b0e81456697b9a5de28d6
Gerrit-Change-Number: 35592
Gerrit-PatchSet: 10
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment