Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66782 )
Change subject: tree/: Convert flashchip write func ptr to enumerate
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File include/flash.h:
https://review.coreboot.org/c/flashrom/+/66782/comment/e7edbb7b_462780be
PS8, Line 229: chip_write_func
There is an inconsistency in enum names at the moment:
probe_func (without chip)
chip_write_func
chip_read_func
block_erase_func (without chip)
decode_range_func (without chip)
I think all the names should be the same: either with or without "chip". And at the moment "without chip" team wins 3:2. I also agree that "chip" prefix is not needed, so my +1 to "without chip".
If you could rename `chip_write_func` and `chip_read_func` that would be great!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I80149de169464b204fb09f1424a86fc645b740fd
Gerrit-Change-Number: 66782
Gerrit-PatchSet: 8
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 09 Sep 2022 08:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment