Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35611 )
Change subject: cli_classic: Tidy up some repeated handling patterns into funcs
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c@79
PS5, Line 79: if (msg)
: fprintf(stderr, "%s", msg);
Shouldn't this be the first message?
Done
https://review.coreboot.org/c/flashrom/+/35611/5/cli_classic.c@293
PS5, Line 293: "in. Aborting.\n");
nit, does it fit in a single line?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/35611
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I54598efdaee2b95cb278b0f2aac05f48bbd95bef
Gerrit-Change-Number: 35611
Gerrit-PatchSet: 7
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 10:42:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment