Brian Norris has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/80807?usp=email )
Change subject: [RFC] flashrom: Don't throw around "delay 1 second" so lightly ......................................................................
[RFC] flashrom: Don't throw around "delay 1 second" so lightly
Waiting a full second is a very long time, especially when default_delay() chooses to busy-loop. This code has been around for a decade, with vague references to user reports:
https://review.coreboot.org/plugins/gitiles/flashrom/+/8ab49e72af8465d4527de...
Still, this logic does not belong in the the high-level library logic, used by all programmers and all chips. If there is a timing issue, it should either be encoded in the appropriate programmer or flashchip timing.
Change-Id: Ie09651fede3f9f03425244c94a2da8bae00315fc Signed-off-by: Brian Norris briannorris@chromium.org --- M flashrom.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/80807/1
diff --git a/flashrom.c b/flashrom.c index 630c69d..f4f9e7f 100644 --- a/flashrom.c +++ b/flashrom.c @@ -2330,9 +2330,6 @@ if (verify && !all_skipped) { msg_cinfo("Verifying flash... ");
- /* Work around chips which need some time to calm down. */ - programmer_delay(flashctx, 1000*1000); - if (verify_all) combine_image_by_layout(flashctx, newcontents, oldcontents); ret = verify_by_layout(flashctx, verify_layout, curcontents, newcontents);