Attention is currently required from: Alexander Goncharov, Stefan Reinauer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77249?usp=email )
Change subject: doc: Copy logo files into flashrom repository
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
maybe it is enough to just add the SVG rather than all of the rendered images?
Initially I just copied the whole directory without thinking about it.
Now you made me thinking! :)
I think, better have the whole directory because maybe we will need different images for different pages (for example)?
I now started doubting that I used the right image in the next patch :\ I need to have another look.
In general it's easier to have the whole dir and use any image or change them if needed, VS copying one at a time. Would you agree?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77249?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I38c1d820be92f2688c5fc4c63a150ab324d8b647
Gerrit-Change-Number: 77249
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Fri, 18 Aug 2023 00:09:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-MessageType: comment
