Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73293 )
Change subject: libpci: drop support for pciutils < 2.2.0
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73293/comment/84aa745e_8e9a608d
PS2, Line 9: releasd
releasd -> released (typo)
Done
https://review.coreboot.org/c/flashrom/+/73293/comment/38a7f409_b4702fd6
PS2, Line 9: an
a
Done
https://review.coreboot.org/c/flashrom/+/73293/comment/11b9d6ec_c0404337
PS2, Line 10: With dropping it
Drop it so that we don't need...
Done
File pcidev.c:
https://review.coreboot.org/c/flashrom/+/73293/comment/31466de9_8f62d50c
PS2, Line 196: new
Good idea (both of them) but I think for a separate patch?
Done in follow up
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73293
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If943db350b561a005d8292a53d9255223db3d571
Gerrit-Change-Number: 73293
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 07 Mar 2023 19:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment