18 Apr
2021
18 Apr
'21
3:45 p.m.
Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer, Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52425 )
Change subject: Revert "Makefile: Explicitly set '-std=c99'" ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2: My understanding is: if original commit breaks so many things then it needs to be reverted now. Fix can be done later, and especially if it requires lots of testing. Sorry.
--
To view, visit https://review.coreboot.org/c/flashrom/+/52425
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I57b5125207de3fd156dface67cba605da893d6aa
Gerrit-Change-Number: 52425
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Idwer Vollering vidwer@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sun, 18 Apr 2021 22:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment