12 Oct
2022
12 Oct
'22
4:35 a.m.
Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68247 )
Change subject: util: add bash completion script ......................................................................
Patch Set 4:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/68247/comment/f879a9cf_47acd8e4 PS4, Line 33: bash-completion
I am wondering, would `bash-comp` be sufficient? is it understandable?
no, because that's a somewhat standard path where the bash-completion tool expects the completion extensions.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68247
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie68bc91c3cea4de2ffdbeffd07e48edd8d5590e1
Gerrit-Change-Number: 68247
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Wed, 12 Oct 2022 04:35:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment