David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42556 )
Change subject: [RFC] Add uncrustify config
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/flashrom/+/42556/3/bitbang_spi.c
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/42556/3/bitbang_spi.c@19
PS3, Line 19: #include <ctype.h>
No, but I think this can be fixed by separating the global headers and local headers with a newline. […]
Fixed in PS4.
To fix it, I updated CB:42555 to group the #includes into three groups: platform.h in its own group since it's special, global #includes, and local #includes. Then I ran uncrustify and uploaded the result.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/42556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib6bd3ab49e841768f07c2705f71be66e9308bbca
Gerrit-Change-Number: 42556
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vadim Bendebury
vbendeb@chromium.org
Gerrit-Comment-Date: Wed, 24 Jun 2020 17:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment