Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/flashrom/+/36946/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/36946/2//COMMIT_MSG@11 PS2, Line 11: strick strict?
But anyway, IIRC, this was fixed lately in Clang...
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/36946/1/libflashrom.c@192 PS1, Line 192: (enum flashrom_test_state)binfo[i].working;
Done. I added some defines for OK, BAD, etc.., otherwise it would be very verbose.
Looks good :)
https://review.coreboot.org/c/flashrom/+/36946/2/util/ich_descriptors_tool/i... File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/36946/2/util/ich_descriptors_tool/i... PS2, Line 155: struct ich_descriptors desc = { 0 }; We just changed it to this to calm compiler warnings ;) I assume Clang complained about this? what version? IIRC, they changed this lately for better compatibility.