19 Dec
2019
19 Dec
'19
10:26 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/flashrom/+/36946/7/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/36946/7/Makefile@33 PS7, Line 33: -Wmissing-field-initializers For GCC, this is already part of -Wextra. But I guess we should disable it for Clang, right? i.e. += -Wno-missing-field-initializers. Can be done in a separate patch, though.
--
To view, visit https://review.coreboot.org/c/flashrom/+/36946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d01f4ff620f4c4111dd675d49ce3254f2360b29
Gerrit-Change-Number: 36946
Gerrit-PatchSet: 8
Gerrit-Owner: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Dec 2019 10:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment