[flashrom-gerrit] [XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase

[Bill XIE (Code Review)]

Attention is currently required from: Aarya, Anastasia Klimchuk, Peter Marheine.

Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email )

Change subject: erasure_layout: Erase larger block only when all sub-block need erase
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS1:
> I think minimizing the number of bytes erased ("safe") is the correct default behavior, regardless. A command-line option to instead reduce the number of erases ("quick-n-dangerous", assumed to operate faster but wear flash faster) might be nice, though.

Agreed.
> default can stay the same as it is now, 50, and then if decided, it can be later changed in a separate 1-line patch.

That is why I insist on considering 1/2 as the default threshold to be a bug, instead of an optimization.