27 Aug
2023
27 Aug
'23
8:14 a.m.
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, Vasily Galkin, roman.stingler@gmail.com.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email )
Change subject: flashchips.c: Add support for IS25WQ040 ......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
Thanks for review! […]
Yes, it's fine.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58179/comment/3455c18c_2c22f345 : PS5, Line 7793: /* QPI enable 0x35, disable 0xF5 */
Removed this commands 0x35, 0xF5 are not mentioned in datasheet. […]
Oh yes I see there is Quad I/O , I missed it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e
Gerrit-Change-Number: 58179
Gerrit-PatchSet: 6
Gerrit-Owner: Vasily Galkin
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: roman.stingler@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Vasily Galkin
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: roman.stingler@gmail.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sun, 27 Aug 2023 08:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vasily Galkin
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment