Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Michael Heimpold has posted comments on this change by Michael Heimpold. ( https://review.coreboot.org/c/flashrom/+/82715?usp=email )
Change subject: flashchips: add support for chip model Winbond W25Q16JV_M
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
Thanks for your review. I've adapted the patch accordingly.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82715/comment/bbbbddc2_70cf1baa?usp... :
PS1, Line 19297: FEATURE_WRSR_EXT2 |
You need to remove this feature bit, it's not needed. […]
Done
https://review.coreboot.org/c/flashrom/+/82715/comment/67bdcf1e_8c5c818d?usp... :
PS1, Line 19320: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
I think this function is better for this chip, it will print more details: […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82715?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ida1ceb5fe31411bef647e5133c5bd0bdb02d7704
Gerrit-Change-Number: 82715
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Heimpold
mhei@heimpold.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Fri, 07 Jun 2024 19:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
