Attention is currently required from: Nico Huber, Miklós Márton, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54190 )
Change subject: stlinkv3_spi.c: Clean up properly on all init error paths
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54190/comment/4c432dc4_766d7459
PS1, Line 7: Cleanup
nit: The verb form has a space: `clean up`
Done
File stlinkv3_spi.c:
https://review.coreboot.org/c/flashrom/+/54190/comment/ff432a60_4e4d8e6e
PS1, Line 443: stlinkv3_command(command, sizeof(command), answer, sizeof(answer), "STLINK_BRIDGE_CLOSE");
Looks like this might be complementary to stlinkv3_spi_open(), but I'm not sure.
Oh yes, there is a STLINK_BRIDGE_INIT_SPI in stlinkv3_spi_open(), maybe it is?
I think Miklós knows the answer! :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9fabf48068635593bc86006c9642d8569eee8447
Gerrit-Change-Number: 54190
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 14 May 2021 04:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment