Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30410 )
Change subject: Fix -Wunused-parameter issues
......................................................................
Patch Set 7:
(1 comment)
Hmmm, lost votes :-/
https://review.coreboot.org/c/flashrom/+/30410/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/30410/5//COMMIT_MSG@10
PS5, Line 10: __attribute__ ((unused)).
We would then still be using __attribute__ ((unused)) anyway :P
I do neither know which compilers can compile flashrom nor which support
the attribute syntax or this particular attribute... Generally, if it's
not ISO C, I'd try to avoid it.
I probably didn't think that far when I wrote the commit message; will
drop that.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/30410
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If831398c91e9f49bd5216a03ed4caaa2a7ab02bd
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Stefan T
stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Oct 2019 15:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment