Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60848 )
Change subject: satasii: remove unused rget_io_perms() ......................................................................
satasii: remove unused rget_io_perms()
The satasii programmer does not use x86 IO Ports. Remove the dependency to it.
Change-Id: I54d65561ff024d3c181d11c6518a4612c2ab0399 Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/60848 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile M satasii.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index b351990..b8287a9 100644 --- a/Makefile +++ b/Makefile @@ -132,7 +132,6 @@ CONFIG_NICREALTEK \ CONFIG_RAYER_SPI \ CONFIG_SATAMV \ - CONFIG_SATASII \
DEPENDS_ON_LIBPCI := \ CONFIG_ATAHPT \ diff --git a/satasii.c b/satasii.c index f9cb5da..a27fc29 100644 --- a/satasii.c +++ b/satasii.c @@ -18,7 +18,6 @@
#include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h"
@@ -102,9 +101,6 @@ uint32_t addr; uint16_t reg_offset;
- if (rget_io_perms()) - return 1; - dev = pcidev_init(satas_sii, PCI_BASE_ADDRESS_0); if (!dev) return 1;