Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection ......................................................................
Patch Set 15:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63724/comment/92f3ea0d_a1f6eb9a PS11, Line 10: has some known and unknown bugs.
The tests are currently a problem when not selecting all programmers.
I remember a conversation last year, about tests and how to build them when some programmers are disabled. At the moment test code (the actual function which runs the test) is guarded by CONFIG_ option. This is because at the moment tests for various programmers live in the same file (lifecycle.c).
Yes that was me who created one file and I started adding tests for various programmers into that one file. That was a convenient approach to begin with, but for future I was planning to split and have individual test file for each programmer (same as source code is).
Individual test files came up in the conversation last year as an alternative to CONFIG_ guards, and probably a more correct alternative. However splitting into individual files was not done because that would be a lot of work, and it was not urgent at that time (CONFIG_ guards could do the job). So the decision was "let's do it later".
Maybe now is that later?
CB:55295