Attention is currently required from: Paul Menzel, Thomas Heijligen, Edward O'Callaghan. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 )
Change subject: hwaccess: fix build on non-x86 targets ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/61194/comment/bd9cc178_9acdb780 PS1, Line 22: Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e
Missing Signed-off-by line?
Done
Patchset:
PS1:
The hwaccess_x86 files should only get compiled on x86 platforms. So as the code which requires it. […]
The hwaccess_x86 headers are included in components of the internal programmer that are also built on non-x86: while there are issues with the Meson configuration (fixed in the following CL), the Makefile build is also broken.
I've now opted to put the x86 guards in the headers rather than in the files that include them because otherwise the guards would need to be duplicated across three other files.