23 Apr
2022
23 Apr
'22
9 p.m.
Attention is currently required from: Nico Huber, Peter Farley. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63798 )
Change subject: ft2232_spi: Reduce read size for FT232H ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63798/comment/cc8f3642_d3482011 PS1, Line 9: FT232H-based devices are unable to read over 256 bytes of flash in one Is this documented anywhere? Or how did you figure this out?
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/63798/comment/145fa391_b7fa057a PS1, Line 291: static struct spi_master spi_master_ft2232 = { I'd prefer having two structs.
--
To view, visit https://review.coreboot.org/c/flashrom/+/63798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2a45fb8ac8ff37bbf01b0cb6b88851cf74af495d
Gerrit-Change-Number: 63798
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Farley far.peter1@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Peter Farley far.peter1@gmail.com
Gerrit-Comment-Date: Sat, 23 Apr 2022 21:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment