Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47004 )
Change subject: spi25.c: Use define const in spi_simple_write_cmd() fn
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47004/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/47004/1//COMMIT_MSG@10
PS1, Line 10: readability
I would beg to differ. It avoids a magic number, though, so I don't really care.
Well I just picked a word to generally explain the idea, 'readability' seemed close enough for the general principle of what is going on here in this patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47004
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1b5ede4435ba014320fa8cf9490dc23cdfba4fd6
Gerrit-Change-Number: 47004
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Shiyu Sun
sshiyu@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Oct 2020 10:29:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment