Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/flashrom/+/47655/10/it85spi.c
File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/10/it85spi.c@240
PS10, Line 240: struct it85spi_data *data = (struct it85spi_data *) flash->mst->spi.data;
Angel, nice to meet you! […]
Good news: data is not const anymore (this is resolved in the earlier commit)!
So I can remove explicit cast from here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47655
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 11
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Eizan Miyamoto
eizan@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Jan 2021 01:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Kurtz
djkurtz@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment