[flashrom-gerrit] Change in flashrom[master]: realtek_mst_i2c_spi.c: Update write protection toggle function

[Shiyu Sun (Code Review)]

Shiyu Sun has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46089 )

Change subject: realtek_mst_i2c_spi.c: Update write protection toggle function
......................................................................

Patch Set 7:

(4 comments)

https://review.coreboot.org/c/flashrom/+/46089/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/46089/6//COMMIT_MSG@11 
PS6, Line 11: The process would be
> Format this as a list? […]

Done

https://review.coreboot.org/c/flashrom/+/46089/6//COMMIT_MSG@11 
PS6, Line 11: protectoin
> protection

Done

https://review.coreboot.org/c/flashrom/+/46089/6/realtek_mst_i2c_spi.c 
File realtek_mst_i2c_spi.c:

https://review.coreboot.org/c/flashrom/+/46089/6/realtek_mst_i2c_spi.c@157 
PS6, Line 157: ret |= realtek_mst_i2c_spi_write_register(fd, 0xF4, 0x9F);
             : 	ret |= realtek_mst_i2c_spi_write_register(fd, 0xF5, GPIO_CONFIG_ADDRESS >> 8);
             : 	ret |= realtek_mst_i2c_spi_write_register(fd, 0xF4, GPIO_CONFIG_ADDRESS & 0xFF);
> Adding the last write inside the function makes it a write-function. […]

Done

https://review.coreboot.org/c/flashrom/+/46089/6/realtek_mst_i2c_spi.c@182 
PS6, Line 182: (toggle ? 0x01 : 0x00)
> agreed, and toggle could really be typed as a bool as well imho.

Done