Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34945 )
Change subject: util/ich_descriptors_tool: use clang's style suggestion
......................................................................
Patch Set 3: Code-Review-1
This would collide with -Wmissing-field-initializers (part of
-Wextra in GCC) that we are about to enable for flashrom.
IIRC, the behaviour also changed in Clang 9.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie80c4c4d70c8ccf357ba8e65f454fc4d4fa8c058
Gerrit-Change-Number: 34945
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Comment-Date: Tue, 24 Sep 2019 20:57:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment