Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Add support for USB SPI protocol V2 ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@7 PS10, Line 7: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@9 PS10, Line 9: Adds
Add
Done
https://review.coreboot.org/c/flashrom/+/41533/10//COMMIT_MSG@9 PS10, Line 9: documentation of it
its documentation
Done
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@875 PS10, Line 875: " protocol = %u\n"
This isn't aligned with the other definitions
Done
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@930 PS10, Line 930:
Double empty line
Done
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@950 PS10, Line 950: unsigned int
I'd rather declare loop variables outside of the loop body for compatibility purposes. […]
Done
https://review.coreboot.org/c/flashrom/+/41533/10/raiden_debug_spi.c@1112 PS10, Line 1112:
Two spaces
Done