Attention is currently required from: Felix Singer, Richard Hughes, Anastasia Klimchuk.
Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64663 )
Change subject: libflashrom: Allow getting the progress_state from the flashctx
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64663/comment/e711d58b_46deefda
PS1, Line 9: External users of the libflashrom API
The feature is for external users, so whatever was the testing needed, it was done outside of flashr […]
Marking Done
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/64663/comment/99c93953_932c2541
PS1, Line 110:
This looks like one superfluous line.
Marking Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/64663/comment/fb3829d2_ee605260
PS1, Line 69: flashrom_get_progress_state(struct flashrom_flashctx *flashctx)
Please write function header in one line as it's done elsewhere
Marking Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64663
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010
Gerrit-Change-Number: 64663
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 26 May 2022 17:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment