Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60113 )
Change subject: physmap: rename to hwaccess_physmap, create own header
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/60113/comment/fcec748d_15ae10e8
PS4, Line 9: Line up physmap with the other hwaccess related code.
Oh, we could make it a hwaccess/ subdir of src/. No wait, there is […]
My plan is to move this to (src)/platform/...
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/60113/comment/61177e8d_c989c56e
PS4, Line 41: #if CONFIG_INTERNAL == 1
Why the guard and why only here? It's just function prototypes, they […]
This isn't needed. Just a bad habit I got from flashrom
--
To view, visit
https://review.coreboot.org/c/flashrom/+/60113
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ieba6f4e94cfc3e668fcb8b3c978de5908aed2592
Gerrit-Change-Number: 60113
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Dec 2021 20:38:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
