Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83969?usp=email )
Change subject: flashchips: Add definitions for Fuldan FM25Q04, FM25Q64 and FM25Q128 ......................................................................
Patch Set 1:
(4 comments)
Patchset:
PS1: Hello Samantaz, thank you for the contribution! I have few comments.
Commit Message:
https://review.coreboot.org/c/flashrom/+/83969/comment/62541d5c_b69e8510?usp... : PS1, Line 7: Fuldan Fuldan -> Fudan (a typo)
https://review.coreboot.org/c/flashrom/+/83969/comment/bd307f86_12b54cc5?usp... : PS1, Line 9: These chips have the exact same characteristics as their 8/16/32 counterparts, : except for the different flash size. Do you have link to the datasheet, if you could add a link in commit message? I will check the definitions then. Thank you!
https://review.coreboot.org/c/flashrom/+/83969/comment/c9c64096_f313f1d3?usp... : PS1, Line 12: Testing status will be updated in a subsequent commit. Just in case for future: usually if you add support for the model, and it is tested, you can set the test status in the same commit.
But I see that here you add 3 models, and then updated test status for another 2, so you can leave it in two commits, all good.