Attention is currently required from: Chen, Thomas Heijligen, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75011 )
Change subject: jlink_spi: add cs=tms option to jlink_spi programmer
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75011/comment/98efc72d_027a7943
PS2, Line 7: spi
Sorry I didn't notice in the first pass: this should be `jlink_spi` , so that it describes more spec […]
Done
Patchset:
PS2:
One more thing I forgot on the first pass: could you please update the manpage, it is here: […]
Done
Patchset:
PS3:
Looks good, Thomas, Joursoir are you fine with the patch?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0cb467fcc2c403a25f260462de0cd020e7022bb1
Gerrit-Change-Number: 75011
Gerrit-PatchSet: 3
Gerrit-Owner: Chen
c@jia.je
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chen
c@jia.je
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Wed, 10 May 2023 02:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment
