Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47452 )
Change subject: spi25.c: Improve spi cmd write ops diags and readability
......................................................................
Patch Set 3:
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
I don't see the point of explicitly initializing the read members of a write command.
It just makes the file more consistent to read as well as help static analyzers.
Wait, what? How can this help static analyzers? Why clutter the code to please mechanical eyes?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47452
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9fc82558035e511ee485fb5aab0bcd3e164c6ba
Gerrit-Change-Number: 47452
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 12:09:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment