Attention is currently required from: Aarya, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine, Simon Buhrow, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535?usp=email )
Change subject: tests: Unit tests for erase function selection algo
......................................................................
Patch Set 21:
(1 comment)
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/67535/comment/a68e8635_832fd787 :
PS20, Line 62: struct test_case* current_test_case; /* Currently executed test case. */
Can this be const, or is there mutability hidden inside it? (If there is, can it be moved into this […]
There was a hidden mutability indeed, `eraseblocks_actual` and `eraseblocks_actual_ind` ! But I moved it into struct all_state, where it can live together with operational `buf`.
So now yes, the `current_test_case` can point to constant. Thank you for good idea.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67535?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Gerrit-Change-Number: 67535
Gerrit-PatchSet: 21
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Peter Marheine
pmarheine@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Thu, 09 Nov 2023 03:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment