Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34413 )
Change subject: flashchips: Add support for N25Q512..1E
......................................................................
Patch Set 2:
Please review this change for an additional variant of an existing chip. The entire N25Qxxx..1E series should be identical but I only have hardware to test the 512Mb version. Should I also add the other sizes but marked with TEST_UNTESTED?
That would be nice. Usually saves some time to add/review them in one go.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/34413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9e8d2c1fc0c09efea7812fa513b45d1a372d06d7
Gerrit-Change-Number: 34413
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Creedon
jcreedon@google.com
Gerrit-Reviewer: Jacob Creedon
jcreedon@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 16:07:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment