29 Sep
2019
29 Sep
'19
4:27 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35478 )
Change subject: flashchips.c: Take GD25LQ128C/D from downstream ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Looks good I think
https://review.coreboot.org/c/flashrom/+/35478/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/35478/4//COMMIT_MSG@7 PS4, Line 7: Take Nit: "take" is rather ambiguous. Maybe use "update" instead?
--
To view, visit https://review.coreboot.org/c/flashrom/+/35478
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4358392520507ddbfc654feb49fa982d49db2f28
Gerrit-Change-Number: 35478
Gerrit-PatchSet: 4
Gerrit-Owner: Alan Green avg@google.com
Gerrit-Reviewer: Alan Green avg@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 29 Sep 2019 14:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment