Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Thomas Heijligen.
Sydney has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82229?usp=email )
Change subject: Add documentation for pico-serprog
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
I applied your suggestions on wording and split the sentence into two to make them less ambiguous. Please have a look again if everything is fine now.
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/82229/comment/c48f1124_0494246b :
PS3, Line 94: over PIO
"over" can be misunderstood. […]
Done
https://review.coreboot.org/c/flashrom/+/82229/comment/bd805fc4_400fd6e9 :
PS3, Line 95: pinouts but implements USB descriptors allowing custom udev-rules.
:
Nothing wrong with what this _says_, but what it _implies_ is a bit confusing. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 4
Gerrit-Owner: Sydney
git@funkeleinhorn.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: J. Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Attention: J. Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 16 May 2024 11:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: J. Neuschäfer
j.neuschaefer@gmx.net
Gerrit-MessageType: comment
