Attention is currently required from: Nico Huber, Angel Pons.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropriate variables with bool
......................................................................
Patch Set 13:
(3 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/b6835d0e_a46461a5
PS13, Line 259: ichspi_lock
Hmmm, maybe `ichspi_is_locked`?
CB:67431
https://review.coreboot.org/c/flashrom/+/66892/comment/2687b0bd_398c5257
PS13, Line 863: write_cmd
This should be renamed, `is_write_cmd` for example.
CB:67431
https://review.coreboot.org/c/flashrom/+/66892/comment/adb207a1_50529bdc
PS13, Line 980: write_cmd
Ditto, `is_write_cmd`
CB:67431
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66892
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830
Gerrit-Change-Number: 66892
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 08 Sep 2022 00:52:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment