15 Oct
2017
15 Oct
'17
2:45 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/21838 )
Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/21838/1/util/ich_descriptors_tool/Makefile File util/ich_descriptors_tool/Makefile:
https://review.coreboot.org/#/c/21838/1/util/ich_descriptors_tool/Makefile@2... PS1, Line 25: override TARGET_OS := $(shell $(CC) $(CPPFLAGS) -E $(SHAREDSRCDIR)/os.h | grep -v '^#' | grep '"' | cut -f 2 -d'"') this line is a little long, though
--
To view, visit https://review.coreboot.org/21838
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25
Gerrit-Change-Number: 21838
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 15 Oct 2017 14:45:32 +0000
Gerrit-HasComments: Yes