14 Jul
2020
14 Jul
'20
1:14 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43416 )
Change subject: flashchips: Add support for Macronix MX25L5121E ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/43416/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/43416/1//COMMIT_MSG@8 PS1, Line 8: With which programmer did you test this?
https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/43416/1/flashchips.c@8577 PS1, Line 8577: spi_chip_write_256
Done
Hrm, I'm not sure but I can see FIXMEs.
--
To view, visit https://review.coreboot.org/c/flashrom/+/43416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I881e2cda938083ba271b2ee0c457d2bbd8e1a766
Gerrit-Change-Number: 43416
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Markgraf steve@steve-m.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 13 Jul 2020 23:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Steve Markgraf steve@steve-m.de
Gerrit-MessageType: comment