Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30995 )
Change subject: ichspi: Add Apollo Lake support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c
File ich_descriptors.c:
https://review.coreboot.org/#/c/30995/1/ich_descriptors.c@244
PS1, Line 244: 7
Ah, it's 17MHz for the read speed, 14MHz for others. It's just an […]
I don't know if it matters. "14 MHz / 17 MHz" may be good.
https://review.coreboot.org/#/c/30995/1/ichspi.c
File ichspi.c:
https://review.coreboot.org/#/c/30995/1/ichspi.c@1758
PS1, Line 1758: num_freg = 16
You might have to scroll down, there is another set at 0xe0.
found it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/30995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c464b5b3d151e6d28d5db96495fe874a0a45718
Gerrit-Change-Number: 30995
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Jan 2019 10:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
